fix(cli): preserve symlinks in sandbox upload#2319
Open
loveRhythm1990 wants to merge 1 commit into
Open
Conversation
Signed-off-by: lr90 <qiuweimin@matrixorigin.cn>
loveRhythm1990
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 16, 2026 16:03
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix standalone
openshell sandbox uploadso symlink sources, including danglingsymlinks, are preserved instead of being dereferenced or rejected during Git-aware
upload planning. This restores the intended behavior documented in the CLI reference.
Related Issue
Fixes #2309
Changes
link.
command path.
Testing
mise run pre-commitpassesenvironment-dependent failure in
proxy::tests::test_forward_public_ip_allowed_without_allowed_ipsbecausedns.googleresolved to198.18.1.240.added)
Additional commands run:
mise exec -- cargo test -p openshell-climise exec -- cargo test -p openshell-cli --test sandbox_upload_integrationmise exec -- cargo test -p openshell-cli symlinkmise exec -- cargo check -p openshell-cligit diff --checkChecklist
behavior)